Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use context when switching to kind-porter #30

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

troy0820
Copy link
Member

@troy0820 troy0820 commented Aug 17, 2023

  • Add kubectl config use-context kind-porter when executing script (mage Deploy needs this)
  • Combine kubeconfig with existing kubeconfig env var.

No test needed.

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820
Copy link
Member Author

Checking to see if this works with some go.work magic.

@troy0820 troy0820 changed the title WIP: Use context when switching to kind-porter Use context when switching to kind-porter Aug 17, 2023
@troy0820
Copy link
Member Author

image

CreateCluster exports the CreateTestCluster to test this. This mage target is not committed.

Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what happens if we run this twice, does it just error out if there's an existing kind-porter cluster? Anyways, lgtm :) maybe a thing we should make an issue for and deal with later tho

@schristoff schristoff merged commit 77c3a69 into getporter:main Aug 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants