Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parameters): add param set generation #1074

Closed
wants to merge 12 commits into from

Conversation

vdice
Copy link
Member

@vdice vdice commented Jun 7, 2020

What does this change

  • Adds Parameter Set generation cmds/logic
  • Refactors previous generation logic into common code and credential-/parameter-specific logic

TODO:

  • add/update documentation

What issue does it fix

Closes #1073
Contributes towards #1053

Notes for the reviewer

Depends on #1068
For changes separate from #1068, see the following commit: 1fbc869

Checklist

  • Unit Tests
  • Documentation TODO
  • Schema (porter.yaml) N/A

@vdice vdice changed the title Feat/gen param set feat(parameters): add param set generation Jun 7, 2020
vdice and others added 11 commits June 9, 2020 09:40
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Co-authored-by: Carolyn Van Slyck <carolyn.vanslyck@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
  * Refactors credentials generation logic into generic generator pkg
  * Adds parameter set generation logic, using common generator code

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
vdice added a commit to vdice/porter that referenced this pull request Jun 9, 2020
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
@vdice
Copy link
Member Author

vdice commented Jun 9, 2020

Oops, botched the rebase on this branch; created a new PR in #1078

@vdice vdice closed this Jun 9, 2020
@vdice vdice deleted the feat/gen-param-set branch June 11, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Generation for Parameter Sets
1 participant