[Vertica] Change: set longer read_timeout #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Jan 16, 2017
| @@ -109,7 +109,8 @@ def run_query(self, query, user): | |||
| 'port': self.configuration.get('port', 5433), | |||
| 'user': self.configuration.get('user', ''), | |||
| 'password': self.configuration.get('password', ''), | |||
| 'database': self.configuration.get('database', '') | |||
| 'database': self.configuration.get('database', ''), | |||
| 'read_timeout': self.configuration.get('read_timeout', 60000) | |||
There was a problem hiding this comment.
This is in seconds? Maybe let's have a lower default - 4 hours (14400)?
|
Yes, seconds https://pypi.python.org/pypi/vertica-python/ (mistakenly thought that millisecond) |
|
Just noticed you added this to configuration, then yes - let's keep the default value same as the default. Also you need to add this to the |
|
Thanks! |
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
[Vertica] Change: set longer read_timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1527