Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DPI-1054 error on Oracle driver #2167 #2322

Closed
wants to merge 1 commit into from
Closed

Fix for DPI-1054 error on Oracle driver #2167 #2322

wants to merge 1 commit into from

Conversation

alon710
Copy link
Contributor

@alon710 alon710 commented Feb 16, 2018

@RichardLitt
Copy link

Thanks @alon710. Good catch. Are there any downsides to removing this? Is it needed in other environments?

@alon710
Copy link
Contributor Author

alon710 commented Feb 21, 2018

Not that I know 😄

Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version of cx_Oracle do you use?

@arikfr
Copy link
Member

arikfr commented Jan 21, 2020

Hi,

(This is a template message, but I mean every word of it. Also you're welcome to reply)

Thank you for making this contribution. While we couldn't bring it to completion and merge, it's still very much appreciated. 🙇

In the past year the Redash code base gone under massive updates: on the backend we moved to Python 3 & RQ instead of Celery and on the frontend we replaced Angular with React. It's very likely this makes this PR irrelevant without significant changes. :-(

I'm closing this PR now. But if you're still interested in making it happen, let me know and I will reopen.

Thanks.

@arikfr arikfr closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants