#292: Customizable series colors #319
Conversation
| 'Purple': '#492970', | ||
| 'Red': '#910000', | ||
| 'Red': '#c42525', | ||
| }); |
There was a problem hiding this comment.
In ng_highchart.js we have a list of colors we use for our charts. Please use the same (and of course, you can sue the constant to define this list and reuse it in ng_highchart.js).
If think this color list if preferable, we can try it out. But we need to make sure it's the same list in both places.
There was a problem hiding this comment.
is ng_highcharts.js a custom file you added?
There was a problem hiding this comment.
btw, I took this palette from highcharts.src.js
There was a problem hiding this comment.
This file:
https://github.com/EverythingMe/redash/blob/master/rd_ui/app/scripts/ng_highchart.js
Out Angular wrapper for highcharts.
It might be their new palette/theme for highcharts 4.0 (we should upgrade at some point).
There was a problem hiding this comment.
I meant, did you write the wrapper? if so, it makes sense for me to modify it.
#292: Customizable series colors
* fix the annoying space error * removes menu divider line if archived fixes getredash#319
#292