chore: inherit BaseSQLQueryRunner in Snowflake query runner #6064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
@drewmcmahon thanks for your contribution! Would you mind rebasing your branch on |
junnplus
force-pushed
the
drewmcmahon/chore-use-basesqlrunner-snowflake
branch
from
632b1a8
to
d052041
Compare
EmilaineBorato
pushed a commit
to sondautilities/sonda_d4b_redash
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Modify
Snowflakequery runner to inheritBaseSQLQueryRunnerinstead ofBaseQueryRunner. Primary intention was to add auto-limit query support, but rather than add those methods to theSnowflakequery runner, I think we can refactor it to inherit from BaseSQLQueryRunner and get it for free.How is this tested?
Added snowflake connection, ran queries and created dashboards successfully.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)