Poetry conversion followup #6440
Conversation
|
@arikfr here's that followup PR. There's an authors field and a maintainers field; I think we can either specify the maintainers individually or not, but we'd still need an email associated with it. For the author field, do you want to keep your name on it as BDFL? We would also need an email address for that. |
|
From the other PR:
I think IFTTT and Zapier have integrations like that but I'm not sure they're free. |
Codecov Report
@@ Coverage Diff @@
## master #6440 +/- ##
=======================================
Coverage 61.08% 61.08%
=======================================
Files 157 157
Lines 12834 12834
Branches 1747 1747
=======================================
Hits 7840 7840
Misses 4754 4754
Partials 240 240 |
|
Ignore that. Hadn't looked at the PR details, so didn't know it could take multiple addresses. 😄 |
pyproject.toml
Outdated
| authors = ["Your Name <you@example.com>"] | ||
| authors = ["Arik Fraimovich <email>"] | ||
| maintainers = [ | ||
| "Justin Clift <email>", |
There was a problem hiding this comment.
Might as well use my justin@postgresql.org address for this. 😄
pyproject.toml
Outdated
| @@ -21,7 +21,12 @@ skip = "migrations" | |||
| name = "redash" | |||
| version = "23.09.0-dev" | |||
| description = "Make Your Company Data Driven. Connect to any data source, easily visualize, dashboard and share your data." | |||
| authors = ["Your Name <you@example.com>"] | |||
| authors = ["Arik Fraimovich <email>"] | |||
There was a problem hiding this comment.
| authors = ["Arik Fraimovich <email>"] | |
| authors = ["Arik Fraimovich <arik@redash.io>"] |
(I should probably start monitoring this email address again 🫣)
| "Justin Clift <email>", | ||
| "Guido (Sid) Petri <email>", | ||
| "Eric Radman <email>", | ||
| ] |
There was a problem hiding this comment.
We can either setup some mailing list for maintainers or have maintainers interested make a PR to add themselves here.
I'm cool with both options with some preference to the first, as otherwise this list will probably become outdated pretty quick.
There was a problem hiding this comment.
I also would prefer a mailing list, personally
There was a problem hiding this comment.
I setup maintainers at redash.io. Whoever wants to be on the distribution list, ping me.
There was a problem hiding this comment.
@arikfr Please add me to that list. 😄
There was a problem hiding this comment.
We should add a comment to show how to request membership or unsubscribe
There was a problem hiding this comment.
Comment added. Hopefully this makes sense but is still concise?
There was a problem hiding this comment.
The comment is good. At least provides the right direction
There was a problem hiding this comment.
There was a problem hiding this comment.
We should probably have a check list of things to do when adding someone as a maintainer:
- Add on GitHub
- Add on Discord
- Add to mailing list
Btw, currently only @guidopetri and @justinclift are on the mailing list. If you want me to add you, send me your email address.
What type of PR is this?
Misc fixes
Description
Followups from #6423
How is this tested?
Ran
poetry lockRelated Tickets & Documents
#6423
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
N/A