Fix: can't handle sigint when running gatt.DeviceManager outside the mainthread #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that it was impossible to set a signal handler for SIGINT in combination with a running gatt.DeviceManager.
Code to reproduce (pseudocode):
This code raises a
KeyboardInterrupt
exception whenSIGINT
was received which is quite unexpected as a signal handler forSIGINT
was set.Also fix subissue related to CTRL + C, which is a
SIGINT
in fact, of #5 (comment) . The fix in my pull request was retrieved from https://stackoverflow.com/a/47947420 .