fix: Allow sending committable from Unfold #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
reviewed
May 22, 2024
| next_message = Message(Value(value, {}, message.timestamp)) | ||
| for value in iterable: | ||
| next_message = Message( | ||
| value=cast(Value[TOutput], value), |
There was a problem hiding this comment.
I don't think this cast should be necessary, more likely somewhere else the types weren't updated
|
@mj0nez I haven't looked at the PR in detail yet since your recent changes, do you need help with the types, or what is the status? I can make some room this week to continue it if so |
Yeah... it would be great if you could take over. |
|
@untitaker Did you get a chance to look at the PR? :) |
untitaker
changed the title
untitaker
approved these changes
Sep 26, 2024
|
discard my earlier comment. this is done now. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the
UnbatchandUnfoldstrategies to the behavior of their counterpartsBatchandReduce.Unbatchnow just submits the values of a submittedValuesBatchone after another to the next step. Therefore, the logic was reduced to rely fully on the passed generator function for building aMessage'sValue.I tried my best fixing the typing issues but there is still one in
arroyo/processing/strategies/batching.py:116with which I had no luck.Closes #369