Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dlq): Removed Generic payload from DLQ Policy #49

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

rahul-kumar-saini
Copy link
Contributor

tl;dr

A DLQ Policy does not care about the Payload type of a Message.

context

Originally a Policy itself would take the message as a parameter and the signature for the handler looked like: handle_invalid_message(message: Message[TPayload], e: InvalidMessage).

That was changed in favor of just having the exception itself hold the message. Removing the generic was forgotten about when the signature changed to handle_invalid_message(e: InvalidMessage).

Copy link
Member

@lynnagara lynnagara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth adding a line to the changelog too

@rahul-kumar-saini
Copy link
Contributor Author

rahul-kumar-saini commented Mar 22, 2022

May be worth adding a line to the changelog too

@lynnagara
The bot auto adds a line with the PR name and adds the version info, where/what could I manually add without messing up the bots workflow?

@lynnagara
Copy link
Member

Ah, just realised one is automatically generated now if it's empty (didn't used to be). So if you want to go with that and not modify the changelog file itself all good. But the way to do it would be to add an entry to the changelog file under the heading Unreleased and write your changes under that. Craft will update the version number next time the publish workflow is run. The auto changelog policy is described here https://github.com/getsentry/craft/blob/47468020b3576960947b7353cb3eb6bd4e36c402/README.md

@rahul-kumar-saini rahul-kumar-saini merged commit d058608 into main Mar 22, 2022
@rahul-kumar-saini rahul-kumar-saini deleted the fix/remove-generic-from-policy branch March 22, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants