Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unneeded Cloud Build step #90

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Jul 6, 2023

This upload step is already taken care of by the artifacts entry in the config.

@phacops phacops requested a review from a team as a code owner July 6, 2023 16:41
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (11371af) 35.09% compared to head (264effd) 35.09%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #90   +/-   ##
=========================================
  Coverage     35.09%   35.09%           
  Complexity      243      243           
=========================================
  Files            48       48           
  Lines          1986     1986           
=========================================
  Hits            697      697           
  Misses         1289     1289           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phacops phacops merged commit d171a04 into main Jul 6, 2023
6 checks passed
@phacops phacops deleted the pierre/remove-unneeded-cloudbuild-step branch July 6, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants