Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support sentry sdk v8 #24

Merged
merged 5 commits into from
May 13, 2024
Merged

feat: Support sentry sdk v8 #24

merged 5 commits into from
May 13, 2024

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented May 13, 2024

BREAKING CHANGE: requires sentry javscript v8
example span https://sentry.sentry.io/performance/trace/c7214e5f9a6fe955d91eff0822017ec2/?fov=0%2C6038.000106811523&node=txn-9446a89bde2e40a3a4b18cece72dd879&statsPeriod=1h&timestamp=1715634918

image

i can't figure out how to attach beforeEach etc to their test spans, but everything else looks okay

todo: could probably strip console colors from the error outputs https://sentry.sentry.io/issues/5345848223/events/72da96f7465846e0af0ba26058bb9d76/?project=4857230

@scttcper scttcper marked this pull request as ready for review May 13, 2024 21:18
@scttcper scttcper requested review from billyvg and a team May 13, 2024 21:18
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scttcper scttcper merged commit dae0d78 into main May 13, 2024
3 checks passed
@scttcper scttcper deleted the scttcper/sentryv8 branch May 13, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants