Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split testsuite into files #24

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

6293
Copy link
Contributor

@6293 6293 commented May 10, 2023

#21
asking for your review @untitaker before migrating rest of the testcases

@6293 6293 requested a review from a team as a code owner May 10, 2023 05:06
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more convenient to embed lhs and rhs into the same file like so:

{
    "lhs": { ... },
    "rhs": { ... }
}

Other than that it looks good to me. I also just learned about insta's glob last night.

@untitaker
Copy link
Member

this is good but github actions is having an incident. i assume that's why the lint job does not run right now

@untitaker untitaker merged commit 7dc0458 into getsentry:main May 10, 2023
@untitaker
Copy link
Member

excellent, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants