support const keyword #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you can merge #28 first, otherwise it would be cumbersome to check the test output |
untitaker
requested changes
May 12, 2023
Comment on lines
+440
to
+441
| if let Some(value) = schema_object.const_value.take() { | ||
| *schema_object = do_normalize(value) |
There was a problem hiding this comment.
can we do *schema_object.const_value = Some(...) instead of overwriting the entire schema object? Very unlikely to matter since const trumps literally anything else, but I don't think we have to destroy all other properties on schema_object
There was a problem hiding this comment.
what we are doing here is normalizing const_value into object with each properties are constant value (lhs to rhs in #15 (comment)). so maybe we could write *schema_object.object = Some(...), but not *schema_object.const_value
untitaker
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15