Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(metrics): Tag backdated bucket creations in statsd [INGEST-954] #1200

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Mar 3, 2022

Adds a metrics.buckets.delay containing the report delay of buckets with a backdated tag.

@jan-auer jan-auer requested a review from a team March 3, 2022 13:31
@jan-auer jan-auer self-assigned this Mar 3, 2022
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternative: we could have a histogram for the value metric.timestamp - now, and tag the histogram with hit/miss

@jan-auer jan-auer enabled auto-merge (squash) March 4, 2022 08:04
@jan-auer jan-auer merged commit cca09fd into master Mar 4, 2022
@jan-auer jan-auer deleted the ref/metrics-statsd-backdated branch March 4, 2022 08:20
jan-auer added a commit that referenced this pull request Mar 9, 2022
* master:
  ref(make): Simplify M1 exports in Makefile (#1206)
  fix(metrics): Wait for project states during aggregator shutdown (#1205)
  fix(test): Find librdkafka on Apple M1 (#1204)
  build: Bump sentry-relay in dev dependencies to 0.8.9 (#1202)
  ref(metrics): Tag backdated bucket creations in statsd (#1200)
  feat(metrics): Extract user satisfaction as tag (#1197)
  fix(statsd): Add new metric_type tag to existing metrics (#1199)
  fix: Apply clippy 1.59 suggestions (#1198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants