feat(replays): add replay events ItemType #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshFerge
commented
Apr 22, 2022
JoshFerge
changed the title
JoshFerge
force-pushed
the
jferg/replay-events-itemtype
branch
5 times, most recently
from
e650814
to
1b36c57
Compare
untitaker
reviewed
Apr 25, 2022
|
Let's please hold back on this until we've determined whether we're gonna send transaction events, a new event type, or a new payload type alltogether. |
JoshFerge
force-pushed
the
jferg/replay-events-itemtype
branch
from
807d067
to
3d0d2ea
Compare
Merged
JoshFerge
commented
Jun 2, 2022
JoshFerge
commented
Jun 2, 2022
| from sentry_sdk.envelope import Envelope | ||
|
|
||
|
|
||
| def generate_replay_event(): |
There was a problem hiding this comment.
TODO: add a test for sending a replay event and replay recording in the same payload
JoshFerge
force-pushed
the
jferg/replay-recordings
branch
from
73845e0
to
3e3882c
Compare
* master: ref(metrics): Stop logging relative bucket size (#1302) fix(metrics): Rename misnamed aggregator option (#1298) fix(server): Avoid a panic in the Sentry middleware (#1301) build: Update dependencies with known vulnerabilities (#1294) fix(metrics): Stop logging statsd metric per project key (#1295) feat(metrics): Limits on bucketing cost in aggregator [INGEST-1132] (#1287) fix(metrics): Track memory footprint more accurately (#1288) build(deps): Bump dependencies (#1293) feat(aws): Add relay-aws-extension crate which implements AWS extension as an actor (#1277) fix(meta): Update codeowners for the release actions (#1286) feat(metrics): Track memory footprint of metrics buckets (#1284)
jan-auer
reviewed
Jun 9, 2022
relay-common/src/constants.rs
Outdated
| @@ -109,6 +109,8 @@ pub enum DataCategory { | |||
| Session = 5, | |||
| /// A profile | |||
| Profile = 6, | |||
| /// Replay Events | |||
| ReplayEvent = 7, | |||
There was a problem hiding this comment.
Note: When moving this live, please ask someone in @getsentry/owners-ingest to issue a new library release of relay so we can add this new data category to Sentry and Snuba.
This will require to regenerate the CABI headers once the name of the enum variant and value are final (see this PR):
- Run
cargo install cbindgenon your machine - Go to the
relay-cabisubfolder - Run
make header - Commit the result into this PR
untitaker
approved these changes
Jun 15, 2022
mitsuhiko
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReplayEventSee spec here for more information:
https://www.notion.so/sentry/Session-Replay-V1-alpha-Ingest-Backend-ae068d1e1d514221b6c3ea2233f360f4
By submitting this pull request, I confirm that Sentry can use, modify, copy, and redistribute this contribution, under Sentry's choice of terms.