ref(actix): Update Store Actor #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
reviewed
Aug 9, 2022
tobias-wilfert
changed the title
flub
approved these changes
Aug 9, 2022
flub
reviewed
Aug 10, 2022
| @@ -30,7 +30,9 @@ | |||
| - Spawn more threads for CPU intensive work. ([#1378](https://github.com/getsentry/relay/pull/1378)) | |||
| - Add missing fields to DeviceContext ([#1383](https://github.com/getsentry/relay/pull/1383)) | |||
| - Improve performance of Redis accesses by not running `PING` everytime a connection is reused. ([#1394](https://github.com/getsentry/relay/pull/1394)) | |||
| - Change to the internals of the store actor. ([#1397](https://github.com/getsentry/relay/pull/1397)) | |||
| - Distinguish between various discard reasons for profiles. ([#1395](https://github.com/getsentry/relay/pull/1395)) | |||
| - Add missing fields to GPUContext ([#1391](https://github.com/getsentry/relay/pull/1391)) | |||
There was a problem hiding this comment.
this accidentally moved to the wrong section?
There was a problem hiding this comment.
i mean, the line below this :)
There was a problem hiding this comment.
I think it should be in the Internal section? (At least that is where the entry for the change of the Healthcheck actor is as well)
This was referenced Aug 16, 2022
Closed
tobias-wilfert
added a commit
that referenced
this pull request
Aug 18, 2022
- This PR updates the Store service to use the generic Addr introduced in #1405, to avoid duplicate code, it moves the shared code out to its own module in relay-system called service. - Some minor changes have been made to address the comments of Jan on #1397. ### Future Steps - With the generic Addr in place the time has come to make a new registry for the services, that replaces the hardcoded current solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
As part of the effort to future-proof Relay, this PR updates the
Storeactor to work with standard Futuresinstead of the former
futurescrate. It also moves away fromactixinternally.The bulk of the changes are in the store.rs file with minor changes
to the envelope.rs file for compatibility with the remaining system
Design Choices
ref(actix): Update Healthcheck Actor [INGEST-1481] #1349
Future Steps