feat(filter): Filter webkit error #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no longer blocked: getsentry/sentry-javascript#7993 (comment) |
olksdr
approved these changes
Jun 1, 2023
| @@ -39,7 +39,8 @@ static EXTENSION_EXC_VALUES: Lazy<Regex> = Lazy::new(|| { | |||
| # See: https://forum.sentry.io/t/error-in-raven-js-plugin-setsuspendstate/481/ | |||
| plugin\.setSuspendState\sis\snot\sa\sfunction| | |||
| # Chrome extension message passing failure | |||
| Extension\scontext\sinvalidated | |||
| Extension\scontext\sinvalidated| | |||
| webkit-masked-url: | |||
There was a problem hiding this comment.
Do we want to have also hidden in there as requested in the linked issue? Or having only webkit-masked-url should be fine?
There was a problem hiding this comment.
the way hidden is included seems a bit too irregular on the events here: getsentry/sentry-javascript#7993 (comment)
whereas almost all have in common webkit-masked-url:
if i want to include hidden then i think the pattern would be something like webkit-masked-url:.*hidden, but I'm not sure if theres a point to this because I don't think we will have false positives with the way this PR does it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getsentry/sentry-javascript#7993
The added regex pattern should filter out the webkit issues linked from here: getsentry/sentry-javascript#7993 (comment)
The source is likely from safari extensions.