ref: Remove old TODOs #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@untitaker can we remove this aswell? relay/relay-general/src/protocol/span.rs Lines 37 to 40 in a1b2f4c |
jan-auer
force-pushed
the
ref/remove-todos
branch
from
269ba64
to
ed56e94
Compare
jan-auer
force-pushed
the
ref/remove-todos
branch
from
ed56e94
to
e1652ff
Compare
untitaker
approved these changes
Mar 12, 2020
jan-auer
commented
Mar 13, 2020
| @@ -38,6 +39,7 @@ fn get_rule(config: &PiiConfig, id: &str) -> Option<RuleRef> { | |||
| } | |||
| } | |||
|
|
|||
| #[allow(clippy::mutable_key_type)] | |||
There was a problem hiding this comment.
This seems to be a false-positive, I'm assuming this is due to Regexes stored inside RuleRef. See https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type
|
Let's do that not just yet. I thought about this recently but then we started another schema discussion like two days ago |
untitaker
approved these changes
Mar 13, 2020
untitaker
approved these changes
Mar 13, 2020
|
@jan-auer your consolidation broke our Python 2 build, as black does not install under Python 2. |
jan-auer
added a commit
that referenced
this pull request
Apr 19, 2021
The `breadcrumb.event_id` attribute was wrongly removed in #522. It is used to link to other Sentry issues from within the breadcrumbs list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some old TODOs. Most notably, this removes the
_relay_processedmarker from event payloads.