Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unreal): Do not serialize broken misc_primary_cpu_brand #650

Merged
merged 3 commits into from
Jul 6, 2020
Merged

fix(unreal): Do not serialize broken misc_primary_cpu_brand #650

merged 3 commits into from
Jul 6, 2020

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Jul 6, 2020 •
edited
Loading

misc_primary_cpu_brand is a typo and was meant to be named misc_primary_gpu_brand. Due to compat, symbolic exposes both. We pop one key (moving it into another more structured context), but not the other.

Always clear both keys such that no misleading information is exposed.

@untitaker untitaker requested a review from a team July 6, 2020 12:08
jan-auer
jan-auer approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

Please add this to the changelog and add a PR description, too.

@untitaker untitaker merged commit bc3e770 into master Jul 6, 2020
@untitaker untitaker deleted the fix/misc-primary-brand branch July 6, 2020 13:46
@joshuarli joshuarli mentioned this pull request Jul 7, 2020
Merged
8 tasks
jan-auer added a commit that referenced this pull request Jul 8, 2020
@jan-auer
Merge branch 'master' into chore/try-auto-n
3571714 
* master:
  fix(server): Forward outcomes in processing mode (#653)
  feat(py): Expose DataCategory via C-ABI (#651)
  build: Update backtrace-rs (#652)
  fix(unreal): Do not serialize broken misc_primary_cpu_brand (#650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @jan-auer