Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): Make the connection timeout configurable #688

Merged
merged 4 commits into from
Jul 29, 2020

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jul 29, 2020

Adds a configuration option for the connection timeout, covering establishing the connection and SSL handshakes. This defaults to 3s, which corresponds to the default TCP packet retransmission window.

For more information, see requests docs and RFC 2988.

@jan-auer jan-auer self-assigned this Jul 29, 2020
@jan-auer jan-auer marked this pull request as ready for review July 29, 2020 10:12
@jan-auer jan-auer requested a review from a team July 29, 2020 10:12
@jan-auer jan-auer merged commit 42f5959 into master Jul 29, 2020
@jan-auer jan-auer deleted the feat/conn-timeout-config branch July 29, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants