Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Fix disabled haproxy tests #838

Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix(tests): Fix disabled haproxy tests #838

merged 1 commit into from
Nov 17, 2020

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Nov 16, 2020 •
edited
Loading

#skip-changelog

Those test fixtures are unused in CI as CI does not install haproxy. I have haproxy installed though.

@untitaker untitaker requested a review from a team November 16, 2020 13:16
jan-auer
jan-auer approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder when this regressed.

@untitaker
Copy link
Member Author

#834

@untitaker untitaker merged commit 8e38623 into master Nov 17, 2020
@untitaker untitaker deleted the fix/fix-haproxy-tests branch November 17, 2020 11:42
jan-auer added a commit that referenced this pull request Nov 17, 2020
@jan-auer
Merge branch 'master' into feat/dynamic-sampling-1
be36340 
* master:
  fix(tests): Fix disabled haproxy tests (#838)
  release: 20.11.0
  doc: Use automatic links (#836)
  doc: Bring back path of an event through relay (#831)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @jan-auer