feat: Add a .no-cache option to event sending #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaduW
reviewed
Jan 14, 2021
|
I'm fine with this but possibly this should not force a refresh if the project is rate limited. |
|
@RaduW in this form it's not safe to merge but something like this I want to have available on production relays for folks to be able to iterate on grouping configs. Currently the experience testing grouping (and data scrubber) changes is awful because you need to wait what seems to be more than a minute for changes to apply. |
* master: fix: Build proper 64-bit Linux wheel release: 0.8.2 chore: Switch to manylinux2010 (#917) meta(py): Changelog for 0.8.2 ci: Add an action to release the library (#916) ref: Remove Compatibility mode for Session Aggregates (#913) release: 21.1.0 ci: Fix clippy command invocation ci: Run clippy via the cargo action feat(server): Ingest and normalize sample rates (#910)
jan-auer
force-pushed
the
feature/no-cache
branch
from
45b3244
to
782f97a
Compare
|
Changed this now to apply later in the pipeline. These changes also ensure that we don't force a refresh if the project is rate limited, @untitaker.
|
jan-auer
changed the title
jan-auer
force-pushed
the
feature/no-cache
branch
from
7eb3b26
to
55981d4
Compare
jan-auer
force-pushed
the
feature/no-cache
branch
from
55981d4
to
b97707f
Compare
untitaker
approved these changes
Jan 28, 2021
jan-auer
added a commit
that referenced
this pull request
Jan 28, 2021
* master: fix(server): Log when recovering from network outages (#918) feat: Add a .no-cache option to event sending (#911) fix: Build proper 64-bit Linux wheel release: 0.8.2 chore: Switch to manylinux2010 (#917) meta(py): Changelog for 0.8.2 ci: Add an action to release the library (#916) ref: Remove Compatibility mode for Session Aggregates (#913)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
no-cacheflag that forces the internal project cache to refresh before processing the envelope. The flag is encoded into the DSN or public key so that it works with any SDK and third-party (including minidumps).For external Relays including PoPs, this has the potential to significantly slow down the end-to-end ingestion timing, but makes it possible to debug issues better by forcing a clean cache before sending. This is useful for iterating on grouping or filter settings. Request handling is not impacted by this change, so SDK event submission should not be impacted.
In general, DSN public keys can now specify optional flags. Flags are appended to the public key in dotted syntax:
https://public-key.flag1.flag2@example.com/1234The flag for cache bypassing is
no-cache.