Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Support DSN auth for the API client #1536

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Mar 21, 2023

This is in support of #1537

Explicitly does not add this as a global cli parameter

@evanpurkhiser evanpurkhiser marked this pull request as draft March 21, 2023 20:50
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-auth-support-dsn-auth-for-the-api-client branch 3 times, most recently from 298a8eb to 4ef20a0 Compare March 21, 2023 22:21
@evanpurkhiser evanpurkhiser marked this pull request as ready for review March 21, 2023 22:21
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-auth-support-dsn-auth-for-the-api-client branch 3 times, most recently from f2d2767 to 4d73cf0 Compare March 21, 2023 22:40
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-auth-support-dsn-auth-for-the-api-client branch from 4d73cf0 to 6164a93 Compare March 21, 2023 22:43
@evanpurkhiser
Copy link
Member Author

Should I add a changelog entry?

@kamilogorek
Copy link
Contributor

We usually generate changelog automatically based on the commit messages, and those are nice so far so you should be fine without doing this by hand. You can also edit minor PRs, like the one about wording change and add #skip-changelog to the description, which will exclude it from the changelog (even after it was already merged).

@evanpurkhiser evanpurkhiser merged commit 28d9891 into master Mar 22, 2023
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-auth-support-dsn-auth-for-the-api-client branch March 22, 2023 18:44
kamilogorek added a commit that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants