ref(crons): Prefer DSN based auth #1541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
commented
Mar 22, 2023
| @@ -2458,7 +2458,7 @@ pub enum MonitorCheckinStatus { | |||
| #[derive(Debug, Deserialize)] | |||
| pub struct MonitorCheckIn { | |||
| pub id: Uuid, | |||
| pub status: MonitorCheckinStatus, | |||
| pub status: Option<MonitorCheckinStatus>, | |||
There was a problem hiding this comment.
status is not returned when using DSN Auth.
evanpurkhiser
commented
Mar 22, 2023
evanpurkhiser
commented
Mar 22, 2023
evanpurkhiser
commented
Mar 22, 2023
| @@ -0,0 +1,8 @@ | |||
| ``` | |||
| $ unset SENTRY_AUTH_TOKEN | |||
| $ SENTRY_DSN=abcd sentry-cli monitors run foo-monitor -- cmd.exe /C echo 123 | |||
There was a problem hiding this comment.
Uses slugs, requires #1540
evanpurkhiser
commented
Mar 22, 2023
| $ unset SENTRY_AUTH_TOKEN | ||
| $ SENTRY_DSN=abcd sentry-cli monitors run foo-monitor -- cmd.exe /C echo 123 | ||
| ? success | ||
| WARN [..] In the future only DSN Auth will be supported for monitor checkins. |
There was a problem hiding this comment.
As mentioned in #1537, when using monitors slugs you CANNOT use Token based auth, as this does not give us context to which organization your monitor is part of.
The plan is to disallow token based authentication completely for monitor checks in the future.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-prefer-dsn-based-auth
branch
from
152a96c
to
d5edd68
Compare
|
Closed in favor of #1545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the cron monitors run command to prefer using DSN auth, including spitting out a warning when DSN Auth is not used.
Requires #1543