ref(monitors): Prefer slugs over guids #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2023
kamilogorek
suggested changes
Mar 22, 2023
kamilogorek
approved these changes
Mar 22, 2023
evanpurkhiser
deleted the
evanpurkhiser/ref-monitors-prefer-slugs-over-guids
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tests, help strings, and some small bits of logic to prefer calling monitor identifiers 'slugs' instead of simply IDs. This is in line with what we're doing for #1537
I would like to wait for the follow up (support DSN auth) to be ready before merging this, as you will ONLY be able to use legacy GUID/ID identifiers for monitors when using toke auth