Add ability to flush events synchronously #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Sentry.
I’m not sure if I can make a pull request here, but I found an issue when handling sentry-clj with AWS Lambda. The issue is that Sentry event is being shut down by serverless during execution.
I added the flush function, which was updated in sentry-java in 2021, to enable synchronous flushing of Sentry events for AWS Lambda environments. This ensures that all events are sent before the serverless execution is completed, addressing the issue of events not being sent.
related issue
getsentry/sentry-java#1023
Thanks for your nice tool.