fix: Crash in Span when Tracer nil #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SentrySpan has a weak reference to SentryTracer to avoid a strong reference cycle. Therefore, ARC can deallocate the SentryTracer if no one keeps a strong reference to the SentryTracer. When calling startChild on SentrySpan and the SentryTracer is nil, the code currently crashes. This is fixed now by adding a SentryNoOpSpan. Fixes GH-1367
marandaneto
reviewed
Oct 21, 2021
marandaneto
reviewed
Oct 21, 2021
marandaneto
approved these changes
Oct 21, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
The SentrySpan has a weak reference to SentryTracer to avoid a strong
reference cycle. Therefore, ARC can deallocate the SentryTracer if no one
keeps a strong reference to the SentryTracer. When calling startChild on
SentrySpan and the SentryTracer is nil, the code currently crashes. This
is fixed now by adding a SentryNoOpSpan.
💡 Motivation and Context
Fixes GH-1367
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps
While this fixes GH-1367, we still need to investigate why the SentryTracer is
nil. With this fix the app doesn't crash anymore, but we lose the corresponding span.