feat: Add flush #2140
Merged
feat: Add flush #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add blocking flush to send out all envelope items. Fixes GH-1013
|
philipphofmann
commented
Sep 12, 2022
Performance metrics 🚀
|
philipphofmann
requested review from
brustolin,
armcknight and
indragiek
as code owners
We need SentryTime also on tvOS so we can make it available everywhere.
philipphofmann
changed the base branch from
master
to
ref/time-available-for-tvos
brustolin
approved these changes
Sep 15, 2022
Sources/Sentry/Public/SentryClient.h
Outdated
Comment on lines
117
to
119
| * Waits synchronously for the SDK to flush out all queued and cached items. Returns if the SDK | ||
| * doesn't complete the flush before the specified timeout period has elapsed or if there is no | ||
| * internet connection. The SDK doesn't dispose the client or the hub. |
There was a problem hiding this comment.
l: The description looks a bit confusion "Returns if the SDK doesn't complete...", if everything work then this function does not return? I know it does, but the phrasing is odd for me (maybe just me). Maybe we could have the error parameter?
There was a problem hiding this comment.
Thanks for the feedback. Is it better now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add blocking flush to send out all envelope items.
This PR is based on #2169.
💡 Motivation and Context
Fixes GH-1013
💚 How did you test it?
Unit tests and real devices.
📝 Checklist
🔮 Next steps