Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix raw log output ids for ui tests #2826

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

armcknight
Copy link
Member

This was producing raw output logs from ui test runs that overwrote each other because they collided when no differentiating pieces existed to interpolate:
image

#skip-changelog

@armcknight armcknight changed the title fix raw log output ids for ui tests that used nonexistent matrix members test: fix raw log output ids for ui tests that used nonexistent matrix members Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #2826 (651c097) into main (ea73af6) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 651c097 differs from pull request most recent head 7bbe122. Consider uploading reports for the commit 7bbe122 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2826      +/-   ##
==========================================
- Coverage   81.33%   81.31%   -0.03%     
==========================================
  Files         258      258              
  Lines       24139    24126      -13     
  Branches    10706    10703       -3     
==========================================
- Hits        19634    19618      -16     
- Misses       4010     4011       +1     
- Partials      495      497       +2     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea73af6...7bbe122. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks 🙏

@armcknight armcknight changed the title test: fix raw log output ids for ui tests that used nonexistent matrix members test: fix raw log output ids for ui tests Mar 23, 2023
@armcknight armcknight merged commit 6472ce5 into main Mar 23, 2023
@armcknight armcknight deleted the armcknight/test/ui-test-raw-output-log-names branch March 23, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants