feat: Add missing properties to SpanContext and Transaction #919

brustolin · 2021-01-29T02:18:50Z

📜 Description

Adding missing properties to SentrySpanContext, and SentryTransaction properties related to the spanContext.

💡 Motivation and Context

We are aiming to complete the Performance API

💚 How did you test it?

Unit Test

📝 Checklist

I reviewed the submitted code
I added tests to verify the changes
I updated the CHANGELOG if needed
I updated the docs if needed
Review from the native team if needed
No breaking changes

🔮

Transaction span childs

…to feature/performance # Conflicts: # Sentry.xcodeproj/project.pbxproj

…to feature/performance

…ntry-cocoa into feature/performance

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>

…ntry-cocoa into feature/performance

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> Co-authored-by: Clang Robot <clang-robot@sentry.io> Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>

…entry/sentry-cocoa into feat/transaction-spancontext

…context

codecov-io · 2021-01-29T08:44:30Z

Codecov Report

Merging #919 (56917e8) into feat/performance-monitoring (436c1b7) will decrease coverage by 0.12%.
The diff coverage is 74.56%.

@@                       Coverage Diff                       @@
##           feat/performance-monitoring     #919      +/-   ##
===============================================================
- Coverage                        94.16%   94.03%   -0.13%     
===============================================================
  Files                               80       80              
  Lines                             3582     3607      +25     
===============================================================
+ Hits                              3373     3392      +19     
- Misses                             209      215       +6

Impacted Files	Coverage Δ
Sources/Sentry/SentrySDK.m	`93.18% <0.00%> (ø)`
Sources/Sentry/SentryHub.m	`91.50% <16.66%> (ø)`
Sources/Sentry/SentrySpanId.m	`52.38% <52.38%> (+9.52%)`	⬆️
Sources/Sentry/SentryTransactionContext.m	`55.55% <55.55%> (ø)`
Sources/Sentry/SentryTransaction.m	`78.37% <78.37%> (-15.18%)`	⬇️
Sources/Sentry/SentryClient.m	`93.43% <100.00%> (ø)`
Sources/Sentry/SentryEnvelope.m	`92.61% <100.00%> (ø)`
Sources/Sentry/SentrySpanContext.m	`100.00% <100.00%> (ø)`
Sources/Sentry/SentryInstallation.m	`86.36% <0.00%> (-9.10%)`	⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436c1b7...ddbb588. Read the comment docs.

philipphofmann

Awesome seeing performance going forward. I added a few comments.

Sources/Sentry/Public/SentrySpanContext.h

Sources/Sentry/Public/SentrySpanStatus.h

Sources/Sentry/Public/SentrySpanContext.h

Tests/SentryTests/SentrySpanContextTests.swift

Sources/Sentry/SentrySpanContext.m

Sources/Sentry/SentryTransaction.m

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>

philipphofmann

Thanks for including all the feedback. This is getting better and better. Can we add more tests so the coverage doesn't go down, please? Keep up the improvements. 👏🏼

Sources/Sentry/Public/SentrySpanContext.h

Sources/Sentry/Public/SentrySpanStatus.h

Sources/Sentry/Public/SentryTransaction.h

Sources/Sentry/SentryTransaction.m

Tests/SentryTests/SentrySpanContextTests.swift

Sources/Sentry/Public/SentrySpanContext.h

Tests/SentryTests/SentryTransactionTests.swift

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>

philipphofmann

Please update the Changelog and decide which comments you still want to resolve. The most important ones are resolved. Thanks for including all the feedback. From my point of with LGTM.

philipphofmann · 2021-02-02T11:04:12Z

Sources/Sentry/SentryTransaction.m

+{
+    NSMutableDictionary<NSString *, id> *serializedData =
+        [[NSMutableDictionary alloc] initWithDictionary:[super serialize]];
+    serializedData[@"spans"] = @[];


l: I guess this is still empty because we still need to add spans? If so, please add a comment, so I don't wonder why.

Exactly. Spans coming soon.

bruno-garcia

nice!

…context

marandaneto

already merged but just wanted to say thanks to @brustolin to work on our reviews and being resilient pointing out improvements we could do further.

* feat: performance monitoring * build: Setup CI for performance monitoring branch * feat: Performance API: Transaction (#908) Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> Co-authored-by: Clang Robot <clang-robot@sentry.io> Co-authored-by: Bruno Garcia <bruno@brunogarcia.com> * test: Add captureTransaction to sample apps (#922) * docs: Improve code comments on transactions (#921) Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com> * feat: Add missing properties to SpanContext and Transaction (#919) Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> Co-authored-by: Bruno Garcia <bruno@brunogarcia.com> * feat: Adding SentrySpan to performance monitoring. (#932) Co-authored-by: Bruno Garcia <bruno@brunogarcia.com> Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> Co-authored-by: Clang Robot <clang-robot@sentry.io> * ref: Remove SentryTransaction from public API. (#950) Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> * feat: Add transaction sampling properties to SentryOptions (#961) * Transaction sampling * Update CHANGELOG.md * Format code * Apply suggestions from code review Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> * Testing and fixes * Using NSNumber for sampler return * Update CHANGELOG.md Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com> * Comment Update * Using NSNumber for tracesSampleRate Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com> * feat: Transaction in Sample App (#971) * Some UI Sample * Format code * Apply suggestions from code review Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> * removing button to download image * Adding status and fixing operation value * Fixed Tests Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> * merge fix * feat: Add sampling rules to SentryHub startTransaction. (#977) * Changing sampled from bool to enum, using TracesSampler * removing name from span * SamplingTests * changelog and code format * Lint Fix * Fix tests * Update Samples/iOS-Swift/iOS-Swift/TraceTestViewController.swift Co-authored-by: Bruno Garcia <bruno@brunogarcia.com> * Random generator for sampling * missing comment * remove sampler from SentryHub+TestInit.h * Apply suggestions from code review Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> Co-authored-by: Bruno Garcia <bruno@brunogarcia.com> Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> * meta: Add missing breaking change to Changelog * performance changelog Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> Co-authored-by: Dhiogo Brustolin <dhiogorb@gmail.com> Co-authored-by: Clang Robot <clang-robot@sentry.io> Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com> Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>

brustolin and others added 25 commits January 18, 2021 18:31

First Transaction send to portal

51c94eb

Merge branch 'master' of https://github.com/getsentry/sentry-cocoa in…

cdadac4

…to feature/performance # Conflicts: # Sentry.xcodeproj/project.pbxproj

Update project.pbxproj

4393fcc

Committing formatted code

99acba2

feat: performance monitoring

6b78bf7

build: Setup CI for performance monitoring branch

e08c892

Merge branch 'feat/performance-monitoring' into feature/performance

42a9cc2

feat: performance monitoring

1025538

build: Setup CI for performance monitoring branch

0b2bbe5

Tests

d1d1ecc

Merge branch 'master' of https://github.com/getsentry/sentry-cocoa in…

b68e131

…to feature/performance

Fixing Transaction to envelope

7101d25

Committing formatted code

84504ff

Removing xCode auto file comment

a4aef74

Merge branch 'feature/performance' of https://github.com/getsentry/se…

153fcd4

…ntry-cocoa into feature/performance

Update Sources/Sentry/Transactions/SentrySpanContext.h

8ee185f

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>

Update Sources/Sentry/Transactions/SentryTransaction.h

5f3bd53

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>

Solve name error and fixing some request

21e0e0a

Merge branch 'feature/performance' of https://github.com/getsentry/se…

9a952d3

…ntry-cocoa into feature/performance

Committing formatted code

45eedf9

Moving files to right place

dbfec18

Merge branch 'feature/performance' of https://github.com/getsentry/se…

225b927

…ntry-cocoa into feature/performance

Committing formatted code

3a51771

feat: Performance API: Transaction (#908)

b59b0ba

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> Co-authored-by: Clang Robot <clang-robot@sentry.io> Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>

Completing SentrySpanContext

7dbb3bd

brustolin requested review from bruno-garcia and philipphofmann January 29, 2021 02:18

brustolin requested a review from HazAT as a code owner January 29, 2021 02:18

brustolin and others added 2 commits January 28, 2021 23:29

Merge branch 'feat/performance-monitoring' of https://github.com/gets…

56917e8

…entry/sentry-cocoa into feat/transaction-spancontext

Committing formatted code

76b0a6d

philipphofmann force-pushed the feat/performance-monitoring branch from 8830e88 to 436c1b7 Compare January 29, 2021 07:47

Merge branch 'feat/performance-monitoring' into feat/transaction-span…

ddbb588

…context

philipphofmann assigned brustolin Jan 29, 2021

philipphofmann reviewed Jan 29, 2021

View reviewed changes

marandaneto reviewed Jan 29, 2021

View reviewed changes

Sources/Sentry/SentrySpanContext.m Outdated Show resolved Hide resolved

marandaneto reviewed Jan 29, 2021

View reviewed changes

Sources/Sentry/SentryTransaction.m Outdated Show resolved Hide resolved

Apply suggestions from code review

c854509

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>

brustolin changed the title ~~Completing SentrySpanContext properties~~ feat: adding some missing properties to spancontext and transaction Jan 29, 2021

brustolin changed the title ~~feat: adding some missing properties to spancontext and transaction~~ feat: adding missing properties to spancontext and transaction Jan 29, 2021

brustolin and others added 3 commits January 29, 2021 09:25

Included some comments and changed swift naming

c775830

Nullable SpanContext operation

1d48596

Committing formatted code

7352049

philipphofmann reviewed Feb 1, 2021

View reviewed changes

brustolin and others added 3 commits February 1, 2021 10:24

Apply suggestions from code review

ae737fa

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>

Committing formatted code

c24a1ac

More tests and comments

959e809

philipphofmann changed the title ~~feat: adding missing properties to spancontext and transaction~~ feat: Add missing properties to SpanContext and Transaction Feb 2, 2021

philipphofmann approved these changes Feb 2, 2021

View reviewed changes

philipphofmann force-pushed the feat/performance-monitoring branch from 352f07e to 380bc9e Compare February 2, 2021 11:19

Update CHANGELOG.md

92cb0cd

bruno-garcia approved these changes Feb 2, 2021

View reviewed changes

brustolin and others added 2 commits February 2, 2021 20:29

Merge branch 'feat/performance-monitoring' into feat/transaction-span…

9f9520d

…context

Committing formatted code

0cbfe97

bruno-garcia merged commit 1195ec0 into feat/performance-monitoring Feb 2, 2021

bruno-garcia deleted the feat/transaction-spancontext branch February 2, 2021 23:51

marandaneto reviewed Feb 3, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add missing properties to SpanContext and Transaction #919

feat: Add missing properties to SpanContext and Transaction #919

brustolin commented Jan 29, 2021 •

edited by philipphofmann

Loading

codecov-io commented Jan 29, 2021

philipphofmann left a comment

philipphofmann left a comment •

edited

Loading

philipphofmann left a comment

philipphofmann Feb 2, 2021

brustolin Feb 2, 2021

bruno-garcia left a comment

marandaneto left a comment

feat: Add missing properties to SpanContext and Transaction #919

feat: Add missing properties to SpanContext and Transaction #919

Conversation

brustolin commented Jan 29, 2021 • edited by philipphofmann Loading

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮

codecov-io commented Jan 29, 2021

Codecov Report

philipphofmann left a comment

Choose a reason for hiding this comment

philipphofmann left a comment • edited Loading

Choose a reason for hiding this comment

philipphofmann left a comment

Choose a reason for hiding this comment

philipphofmann Feb 2, 2021

Choose a reason for hiding this comment

brustolin Feb 2, 2021

Choose a reason for hiding this comment

bruno-garcia left a comment

Choose a reason for hiding this comment

marandaneto left a comment

Choose a reason for hiding this comment

brustolin commented Jan 29, 2021 •

edited by philipphofmann

Loading

philipphofmann left a comment •

edited

Loading