Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate setRelease, setDist and migrate users to passing release/dist in init. (Works already) #196

Closed
jennmueng opened this issue Feb 17, 2021 · 0 comments · Fixed by #213

Comments

@jennmueng
Copy link
Member

setRelease and setDist are deprecated on RN, we should do the same here on Cordova.

/**
* Sets the release on the event.
*/
export function setRelease(release: string): void {
configureScope((scope: Scope) => {
scope.setExtra('__sentry_release', release);
});
}
/**
* Sets the dist on the event.
*/
export function setDist(dist: string): void {
configureScope((scope: Scope) => {
scope.setExtra('__sentry_dist', dist);
});
}

jennmueng added a commit that referenced this issue Mar 19, 2021
As the Android native bridge has no support for setRelease and setDist which set __sentry_release and __sentry_dist as an extra, we remove these methods in favor of passing release and dist to init.
We also have the SENTRY_RELEASE environment variable that is set at buildtime set the release on init instead.

Closes #196
jennmueng added a commit that referenced this issue Mar 22, 2021
#213)

In previous versions, we hadsetRelease and setDist which set __sentry_release and __sentry_dist as an extra, we remove these methods in favor of passing release and dist to init. This removes the existing code on the iOS native bridge that handles this, and we did not add support for this on the Android bridge.

We also have the SENTRY_RELEASE environment variable that is built by the script at build time and matches the sourcemaps set the release on init instead of setting it in a JS event processor. This way we have the auto release set on native events as well.

Closes #196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant