Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test on iOS beta channel due to Flutter bug #1399

Merged
merged 11 commits into from
Apr 20, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 19, 2023

📜 Description

#skip-changelog

💡 Motivation and Context

flutter/flutter#124340

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a2f34bd) 89.91% compared to head (efdd699) 89.91%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           fix/logging-async-gap    #1399   +/-   ##
======================================================
  Coverage                  89.91%   89.91%           
======================================================
  Files                        179      179           
  Lines                       5761     5761           
======================================================
  Hits                        5180     5180           
  Misses                       581      581           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
If CI will be happy too.

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 322.63 ms 361.40 ms 38.77 ms
Size 6.06 MiB 7.03 MiB 993.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6d7a391 331.94 ms 367.04 ms 35.10 ms
ad69abc 297.35 ms 385.89 ms 88.54 ms
559d28f 302.35 ms 339.53 ms 37.18 ms
4efee31 308.92 ms 368.68 ms 59.76 ms
e2d89fc 323.84 ms 376.23 ms 52.39 ms
8ced2dc 295.58 ms 336.49 ms 40.91 ms
e66e71e 296.84 ms 345.43 ms 48.59 ms
1c6eb5b 350.69 ms 393.86 ms 43.17 ms
9928a74 375.26 ms 456.30 ms 81.04 ms
464b4d0 320.71 ms 380.02 ms 59.31 ms

App size

Revision Plain With Sentry Diff
6d7a391 5.94 MiB 6.95 MiB 1.01 MiB
ad69abc 6.06 MiB 7.09 MiB 1.03 MiB
559d28f 5.94 MiB 6.92 MiB 1001.70 KiB
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB
e2d89fc 6.06 MiB 7.03 MiB 989.37 KiB
8ced2dc 6.06 MiB 7.03 MiB 990.29 KiB
e66e71e 6.06 MiB 7.09 MiB 1.03 MiB
1c6eb5b 5.94 MiB 6.92 MiB 1001.53 KiB
9928a74 5.94 MiB 6.96 MiB 1.02 MiB
464b4d0 6.06 MiB 7.03 MiB 990.27 KiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1247.90 ms 1260.00 ms 12.10 ms
Size 8.10 MiB 9.17 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3637a22 1290.39 ms 1318.42 ms 28.03 ms
d7758e8 1271.69 ms 1288.08 ms 16.39 ms
5aba417 1265.31 ms 1287.90 ms 22.59 ms
22ed6cb 1277.41 ms 1283.76 ms 6.35 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
e5b744f 1250.82 ms 1284.46 ms 33.64 ms
6d7a391 1265.65 ms 1289.98 ms 24.33 ms
7f2b01d 1253.92 ms 1266.70 ms 12.78 ms
6325c3b 1266.52 ms 1291.06 ms 24.54 ms

App size

Revision Plain With Sentry Diff
3637a22 8.09 MiB 9.07 MiB 1001.02 KiB
d7758e8 8.15 MiB 9.12 MiB 989.76 KiB
5aba417 8.16 MiB 9.17 MiB 1.01 MiB
22ed6cb 8.10 MiB 9.17 MiB 1.08 MiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
e5b744f 8.09 MiB 9.07 MiB 1001.19 KiB
6d7a391 8.16 MiB 9.16 MiB 1.01 MiB
7f2b01d 8.16 MiB 9.16 MiB 1.00 MiB
6325c3b 8.16 MiB 9.17 MiB 1.01 MiB

@marandaneto marandaneto changed the base branch from main to fix/logging-async-gap April 19, 2023 12:20
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it flakiness or the fix didn't help? The integration tests failed. @marandaneto

@marandaneto
Copy link
Contributor Author

Is it flakiness or the fix didn't help? The integration tests failed. @marandaneto

Works locally but not on CI, so it's not flaky.

@marandaneto marandaneto merged commit 6893f87 into fix/logging-async-gap Apr 20, 2023
@marandaneto marandaneto deleted the fix/fluter-beta-compile-ios branch April 20, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants