Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new cache page #9949

Merged
merged 14 commits into from
May 22, 2024
Merged

add new cache page #9949

merged 14 commits into from
May 22, 2024

Conversation

lizokm
Copy link
Contributor

@lizokm lizokm commented May 7, 2024

Add new cache product page.

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs 🛑 Canceled (Inspect) May 22, 2024 5:13pm

Copy link

codecov bot commented May 7, 2024

Bundle Report

Changes will increase total bundle size by 339 bytes ⬆️

Bundle name Size Change
sentry-docs-server 7.42MB 348 bytes ⬆️
sentry-docs-edge-server 461.49kB 3 bytes ⬇️
sentry-docs-client 6.18MB 6 bytes ⬇️

@lizokm lizokm requested a review from bcoe May 7, 2024 22:37
@lizokm
Copy link
Contributor Author

lizokm commented May 7, 2024

@bcoe still need to add images and videos

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some copyedits!

docs/product/performance/cache-monitoring/index.mdx Outdated Show resolved Hide resolved
docs/product/performance/cache-monitoring/index.mdx Outdated Show resolved Hide resolved
docs/product/performance/cache-monitoring/cache-page.mdx Outdated Show resolved Hide resolved
docs/product/performance/cache-monitoring/cache-page.mdx Outdated Show resolved Hide resolved
docs/product/performance/cache-monitoring/cache-page.mdx Outdated Show resolved Hide resolved
docs/product/performance/cache-monitoring/cache-page.mdx Outdated Show resolved Hide resolved
docs/product/performance/cache-monitoring/cache-page.mdx Outdated Show resolved Hide resolved
@bcoe
Copy link
Member

bcoe commented May 8, 2024

@bcoe still need to add images and videos

@lizokm I have a testing account we can use. Just let me know when you'd like to do so 😄

@DominikB2014
Copy link
Contributor

@lizokm Mind if I put a couple of changes into this Pr, or shall I open a new one?

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
DominikB2014 and others added 3 commits May 22, 2024 12:12
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
@DominikB2014
Copy link
Contributor

@vivianyentran I made some changes to address some of your comments, mind taking another look?

We're looking at merging this today if possible for our EA release. Between EA and GA we'll be pushing several improvements to the docs like videos, more details on auto instrumentation, but i think the content in this PR is good for EA!

@DominikB2014 DominikB2014 merged commit 0d61933 into master May 22, 2024
6 checks passed
@DominikB2014 DominikB2014 deleted the add/caches-product-docs branch May 22, 2024 17:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants