Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Function support #1085

Merged
merged 9 commits into from
Jul 10, 2021
Merged

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jun 24, 2021

Supersedes: #529

@bruno-garcia bruno-garcia changed the title gcp Google Cloud Function support Jun 24, 2021
@bruno-garcia
Copy link
Member Author

Testing this is another story though.

Worked while testing locally: https://sentry.io/organizations/sentry-sdks/issues/2473539774/?query=is%3Aunresolved

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2021

Codecov Report

Merging #1085 (2e7d79e) into main (7d008a9) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   80.73%   80.83%   +0.10%     
==========================================
  Files         194      195       +1     
  Lines        6363     6391      +28     
  Branches     1411     1412       +1     
==========================================
+ Hits         5137     5166      +29     
  Misses        764      764              
+ Partials      462      461       -1     
Impacted Files Coverage Δ
.../Sentry.AspNetCore.Grpc/SentryBuilderExtensions.cs 43.75% <ø> (ø)
...DependencyInjection/ServiceCollectionExtensions.cs 100.00% <ø> (ø)
...entry.AspNetCore/SentryAspNetCoreLoggerProvider.cs 100.00% <ø> (ø)
.../Sentry.AspNetCore/SentryAspNetCoreOptionsSetup.cs 100.00% <ø> (ø)
src/Sentry.AspNetCore/SentryStartupFilter.cs 100.00% <ø> (ø)
src/Sentry.Google.Cloud.Functions/SentryStartup.cs 100.00% <100.00%> (ø)
src/Sentry/Internal/Http/HttpTransport.cs 90.57% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d008a9...2e7d79e. Read the comment docs.

@bruno-garcia bruno-garcia enabled auto-merge (squash) July 10, 2021 17:30
@bruno-garcia bruno-garcia merged commit 2ee1a05 into main Jul 10, 2021
@bruno-garcia bruno-garcia deleted the feat/google-cloud-functions branch July 10, 2021 17:30
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- Google Cloud Function support([#1085](https://github.com/getsentry/sentry-dotnet/pull/1085))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 2e7d79e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants