feat: Add ClientOptions.SendDefaultPii #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleptric
requested review from
kamilogorek,
AbhiPrasad and
phacops
and removed request for
kamilogorek
|
Yes, it's a source of PII as well |
|
While the |
AbhiPrasad
approved these changes
Nov 2, 2022
rhcarvalho
reviewed
Nov 2, 2022
| - fix: Scope values should not override Event values (#446) | ||
| - feat: Extend User inteface by adding Data, Name and Segment (#483) | ||
| - feat: Make maximum amount of spans configurable (#460) | ||
| - feat: Add ClientOptions.SendDefaultPii #485 |
There was a problem hiding this comment.
Happy to see the Sentry Go SDK evolving!
One suggestion: initialisms like "PII" are spelled with a consistent case as per Go community conventions https://github.com/golang/go/wiki/CodeReviewComments#initialisms.
The option could be called ClientOptions.SendDefaultPII.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
scope.SetUserhas to be explicitly called by the user, I did not add a check forSendDefaultPiithere.Closes #175