Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): Use vendored bagggage implementation in propagator #573

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

tonyo
Copy link
Contributor

@tonyo tonyo commented Feb 6, 2023

After #568, we can finally fix the issue in the propagator that resulted in dropping baggage.
Now we only use our vendored baggage implementation with the fixes that hopefully make our implementation consistent with baggage implementations in other Sentry SDKs.

@tonyo tonyo marked this pull request as draft February 6, 2023 16:44
@tonyo tonyo marked this pull request as ready for review February 6, 2023 16:52
@tonyo tonyo requested a review from cleptric February 6, 2023 16:52
@tonyo tonyo self-assigned this Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 79.13% // Head: 79.14% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a835f6f) compared to base (3964ece).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   79.13%   79.14%   +0.01%     
==========================================
  Files          38       38              
  Lines        3853     3856       +3     
==========================================
+ Hits         3049     3052       +3     
  Misses        703      703              
  Partials      101      101              
Impacted Files Coverage Δ
otel/propagator.go 92.00% <100.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tonyo tonyo merged commit bb6e2bd into master Feb 6, 2023
@tonyo tonyo deleted the tonyo/fix-baggage-vendored-propagator branch February 6, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants