Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Do not test with GOPATH mode anymore #618

Merged
merged 1 commit into from
Apr 3, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 0 additions & 53 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,56 +69,3 @@ jobs:
go: ["1.20", "1.19", "1.18"]
os: [ubuntu, windows, macos]
fail-fast: false
# Test the GOPATH mode with the oldest Go version we support
test-gopath:
name: GOPATH Mode
runs-on: ubuntu-latest
env:
# We use two paths in GOPATH.
# The first one is where 'go get' will download dependencies, and
# the second is where sentry-go itself will be checked out.
GOPATH: ${{ github.workspace }}/deps:${{ github.workspace }}/main
GO111MODULE: "off"
WORKDIR: ${{ github.workspace }}/main/src/github.com/getsentry/sentry-go
defaults:
run:
working-directory: ${{ env.WORKDIR }}
steps:
- uses: actions/setup-go@v3
with:
go-version: "1.18"
- uses: actions/checkout@v3
with:
path: ${{ env.WORKDIR }}
# TODO: cache dependencies
# - uses: actions/cache@v2
# with:
# # In order:
# # * GOPATH with dependencies (but without sentry-go)
# # * GOPATH with sentry-go installed package objects (*.a files)
# # * Build cache (Linux)
# path: |
# ${{ github.workspace }}/deps
# ${{ github.workspace }}/main/pkg
# ~/.cache/go-build
# key: gopath-${{ github.ref }}
# restore-keys: |
# gopath-
- name: Remove Unsupported Code
run: |
# Iris requires Module mode, therefore we delete the relevant code to
# skip testing it in GOPATH mode.
rm -vrf ./iris/ ./_examples/iris/

# OTel module cannot be built right now with Go 1.18 because the latest "main" of
# opentelemetry-go use Go 1.19 features.
rm -vrf ./otel/
- name: Download Dependencies
run: go get -d -t -v ./...
- name: Build
run: go build ./...
- name: Vet
run: go vet ./...
- name: Test
run: make test-race
timeout-minutes: 10