Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements #803

Merged
merged 2 commits into from
Apr 2, 2024
Merged

minor improvements #803

merged 2 commits into from
Apr 2, 2024

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Mar 30, 2024

Was browsing through code and made some minor improvements.

#skip-changelog

@ribice ribice requested a review from cleptric March 30, 2024 00:26
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 81.24%. Comparing base (c10f51e) to head (10e56fb).

Files Patch % Lines
sentry.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   81.17%   81.24%   +0.07%     
==========================================
  Files          49       49              
  Lines        4127     4122       -5     
==========================================
- Hits         3350     3349       -1     
+ Misses        635      632       -3     
+ Partials      142      141       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ribice ribice merged commit f9c3e8b into master Apr 2, 2024
20 of 21 checks passed
@ribice ribice deleted the cleanup branch April 2, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants