Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add ability to skip frames (#852)" #882

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Sep 8, 2024

This reverts commit d95747f.

This didn't turn out really useful, we need to find a better way.

This reverts commit d95747f.

# Conflicts:
#	CHANGELOG.md
#	stacktrace.go
@cleptric cleptric self-assigned this Sep 8, 2024
@cleptric cleptric requested a review from ribice September 8, 2024 22:32
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.94%. Comparing base (871a366) to head (384db15).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
client.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
+ Coverage   82.82%   82.94%   +0.11%     
==========================================
  Files          55       55              
  Lines        4622     4619       -3     
==========================================
+ Hits         3828     3831       +3     
+ Misses        637      633       -4     
+ Partials      157      155       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleptric cleptric merged commit 61d84f8 into master Sep 9, 2024
25 checks passed
@cleptric cleptric deleted the revert-skip-frames branch September 9, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants