Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default checksum #126

Closed
dcramer opened this issue Dec 21, 2014 · 3 comments
Closed

Disable default checksum #126

dcramer opened this issue Dec 21, 2014 · 3 comments

Comments

@dcramer
Copy link
Member

dcramer commented Dec 21, 2014

Per discussion in GH-125, we should disable the default client-side checksum (unless we're certain it's going to be better than the server can be). We should still provide the ability for the Event Builder to send checksums, it would just require user intervention.

@ColinHebert
Copy link

This behaviour has been corrected in July 2013:
41cda81

Patch already available in those versions:
v3.1 v3.1.1 v3.1.2 v4.1 v4.1.1 v4.1.2 v4.2 v5.0 v5.0.1

@ColinHebert
Copy link

The more general fix for the behaviour (not specific to message logs) is from April 2013:

4d99d5e

Every single version since v3.0 (since the entire rewrite), has this behaviour.

@ColinHebert
Copy link

All of that being said, based on the discussion in #125:

A hash must be a 32 character md5 checksum of the event

The current method we provide to generate a hash relies on CRC32 rather than md5, this can be fixed:
https://github.com/getsentry/raven-java/blob/v5.0.1/raven/src/main/java/net/kencochrane/raven/event/EventBuilder.java#L64

Could you give more details on how the said hash is generated (order of the arguments, etc.) so raven can produce a hash similar to the one provided by Sentry (if necessary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants