-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HintUtils.isFromHybridSdk
and HintUtils.setIsFromHybridSdk
should use hints instead
#2525
Comments
@krystofwoldrich I believe this method was introduced by you, have you considered this use case? |
@marandaneto RN Did not migrate to calling Maybe we can use the contexts What do you mean by should use hints? |
The SDK already had something similar called
I don't know the solution for this as of now, would need to think thru it. |
I've tested this with RN and the native crashes are not marked as hybrid even after setting the RN SDK name and version. I've also tested regular Event hint
|
|
Thanks for the details. So Or am I missing something. |
Based on the latest updates from getsentry/team-mobile#48 This won't be an issue as the native SDKs shipped with Hybrids will be named |
@krystofwoldrich could we close this issue in favor of getsentry/team-mobile#48? |
Integration
sentry-android
Build System
Gradle
AGP Version
7.0.0
Proguard
Disabled
Version
6.13.1
Steps to Reproduce
Events captured on Hybrid SDKs directly in the native layer (Java/Kotlin) will not add extra context on the
DefaultAndroidEventProcessor
,ScreenshotEventProcessor
, etc.The reason is that the
HintUtils.isFromHybridSdk
method checks if the event was created by a certain SDK prefix.After those changes:
Where the
name
andversion
are actually the name and version of the Hybrid SDK, every event will be considered coming from the Hybrid SDK even though they were captured directly in the native layer.Expected Result
Events will be enriched with extra context
Actual Result
Events won't be enriched with extra context
The text was updated successfully, but these errors were encountered: