Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent profiling 2 - added list of transactions #2218

Merged

Conversation

stefanosiano
Copy link
Member

📜 Description

We want to support concurrent transactions. In order to do it, we are going to add the list of transactions occurred during a profile.
This pr adds the list of transactions occurred during a profile to the data sent in the envelope payload.
This is the second part of concurrent profiling support, after this pr

💡 Motivation and Context

We want to avoid situations where the user cannot profile his transaction due to automatic transactions occurring at the same time, as pointed in this issue
The strategy we will follow is described here

💚 How did you test it?

Added unit test to check concurrent profiling logic
Added ui test to check the timestamps of transactions occurred during a profile

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

…ofiling-logic

# Conflicts:
#	sentry-android-core/src/main/java/io/sentry/android/core/AndroidTransactionProfiler.java
added unit/ui tests
added CollectionUtils.map method
added unit/ui tests
added CollectionUtils.map method
…at the last transaction has the same timestamp of the profile
@codecov-commenter
Copy link

Codecov Report

Merging #2218 (6a763b7) into feat/concurrent-profiling-data (4abe8f5) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@                         Coverage Diff                          @@
##             feat/concurrent-profiling-data    #2218      +/-   ##
====================================================================
- Coverage                             80.45%   80.42%   -0.04%     
  Complexity                             3366     3366              
====================================================================
  Files                                   241      241              
  Lines                                 12416    12421       +5     
  Branches                               1652     1653       +1     
====================================================================
  Hits                                   9989     9989              
- Misses                                 1804     1809       +5     
  Partials                                623      623              
Impacted Files Coverage Δ
.../src/main/java/io/sentry/util/CollectionUtils.java 44.44% <0.00%> (-10.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stefanosiano stefanosiano marked this pull request as ready for review August 19, 2022 13:16
@stefanosiano stefanosiano merged commit eba80a2 into feat/concurrent-profiling-data Aug 31, 2022
@stefanosiano stefanosiano deleted the feat/concurrent-profiling-logic branch August 31, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants