Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modules for OTEL #2345

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Add modules for OTEL #2345

merged 2 commits into from
Nov 10, 2022

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Nov 8, 2022

#skip-changelog

📜 Description

New gradle modules to contain the

  • sentry-opentelemetry-agent: OTEL Java Agent producing an agent JAR that contains Sentry and adds Sentry to the bootstrap classloader.
  • sentry-opentelemetry-agentcustomization: Config classes for configuring the Java OTEL agent and hooking up our SpanProcessor
  • sentry-opentelemetry-core: Our SpanProcessor and propagator will be contained here

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0ee226e

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 292.88 ms 336.08 ms 43.21 ms
Size 1.73 MiB 2.32 MiB 609.88 KiB

@codecov-commenter
Copy link

Codecov Report

Base: 80.36% // Head: 80.36% // No change to project coverage 👍

Coverage data is based on head (0ee226e) compared to base (9528661).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             feat/otel    #2345   +/-   ##
============================================
  Coverage        80.36%   80.36%           
  Complexity        3670     3670           
============================================
  Files              290      290           
  Lines            13712    13712           
  Branches          1801     1801           
============================================
  Hits             11020    11020           
  Misses            2001     2001           
  Partials           691      691           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adinauer adinauer mentioned this pull request Nov 9, 2022
21 tasks
dependencies {
compileOnly(projects.sentry)

compileOnly("io.opentelemetry:opentelemetry-sdk:${Config.Libs.otelVersion}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'd need some docs or something around that, so people don't expect to add sentry and that it supports OTel out of the box

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there'll need to be some OTEL specific docs that suggest how you can combine Sentry and OTEL, e.g. by using our agent JAR. I already have it on the TODOs here #2327

@adinauer adinauer merged commit 425ede7 into feat/otel Nov 10, 2022
@adinauer adinauer deleted the feat/otel-modules branch November 10, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants