-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modules for OTEL #2345
Add modules for OTEL #2345
Conversation
|
Performance metrics 🚀
|
Codecov ReportBase: 80.36% // Head: 80.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## feat/otel #2345 +/- ##
============================================
Coverage 80.36% 80.36%
Complexity 3670 3670
============================================
Files 290 290
Lines 13712 13712
Branches 1801 1801
============================================
Hits 11020 11020
Misses 2001 2001
Partials 691 691 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dependencies { | ||
compileOnly(projects.sentry) | ||
|
||
compileOnly("io.opentelemetry:opentelemetry-sdk:${Config.Libs.otelVersion}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we'd need some docs or something around that, so people don't expect to add sentry and that it supports OTel out of the box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there'll need to be some OTEL specific docs that suggest how you can combine Sentry and OTEL, e.g. by using our agent JAR. I already have it on the TODOs here #2327
#skip-changelog
📜 Description
New gradle modules to contain the
sentry-opentelemetry-agent
: OTEL Java Agent producing an agentJAR
that contains Sentry and adds Sentry to the bootstrap classloader.sentry-opentelemetry-agentcustomization
: Config classes for configuring the Java OTEL agent and hooking up ourSpanProcessor
sentry-opentelemetry-core
: OurSpanProcessor
and propagator will be contained here💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps