-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging for OpenTelemetry integration #2425
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f1150bc | 352.62 ms | 453.27 ms | 100.65 ms |
a04f788 | 321.78 ms | 354.12 ms | 32.35 ms |
4a9c176 | 319.77 ms | 363.20 ms | 43.43 ms |
90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
3695453 | 314.63 ms | 353.10 ms | 38.47 ms |
16371c5 | 314.02 ms | 394.54 ms | 80.52 ms |
507f924 | 342.51 ms | 402.65 ms | 60.14 ms |
703d523 | 330.27 ms | 377.66 ms | 47.39 ms |
4a9c176 | 320.62 ms | 334.68 ms | 14.06 ms |
87598a5 | 310.41 ms | 373.27 ms | 62.86 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f1150bc | 1.73 MiB | 2.33 MiB | 615.66 KiB |
a04f788 | 1.73 MiB | 2.32 MiB | 609.88 KiB |
4a9c176 | 1.73 MiB | 2.33 MiB | 612.69 KiB |
90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
3695453 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
16371c5 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
507f924 | 1.73 MiB | 2.32 MiB | 609.95 KiB |
703d523 | 1.73 MiB | 2.33 MiB | 613.23 KiB |
4a9c176 | 1.73 MiB | 2.33 MiB | 612.69 KiB |
87598a5 | 1.73 MiB | 2.33 MiB | 614.63 KiB |
Previous results on branch: feat/test-error-otel-transaction-link
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fa42bf4 | 303.78 ms | 353.70 ms | 49.93 ms |
1d94fa8 | 330.26 ms | 403.30 ms | 73.04 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fa42bf4 | 1.73 MiB | 2.33 MiB | 613.23 KiB |
1d94fa8 | 1.73 MiB | 2.33 MiB | 615.83 KiB |
sentry-opentelemetry/sentry-opentelemetry-core/src/test/kotlin/SentrySpanProcessorTest.kt
Show resolved
Hide resolved
Codecov ReportBase: 80.05% // Head: 80.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2425 +/- ##
============================================
- Coverage 80.05% 80.03% -0.03%
- Complexity 3802 3806 +4
============================================
Files 306 306
Lines 14312 14402 +90
Branches 1903 1904 +1
============================================
+ Hits 11458 11527 +69
- Misses 2108 2127 +19
- Partials 746 748 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📜 Description
Add log statements to
SentrySpanProcessor
,SentryPropagator
andOpenTelemetryLinkErrorEventProcessor
.I also added some tests for
OpenTelemetryLinkErrorEventProcessor
.💡 Motivation and Context
💚 How did you test it?
Manually with Spring Boot sample.
📝 Checklist
🔮 Next steps