Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for OpenTelemetry integration #2425

Merged
merged 6 commits into from
Dec 22, 2022

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Dec 13, 2022

📜 Description

Add log statements to SentrySpanProcessor, SentryPropagator and OpenTelemetryLinkErrorEventProcessor.

I also added some tests for OpenTelemetryLinkErrorEventProcessor.

💡 Motivation and Context

💚 How did you test it?

Manually with Spring Boot sample.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9cdea77

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 322.10 ms 363.38 ms 41.27 ms
Size 1.73 MiB 2.33 MiB 615.83 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f1150bc 352.62 ms 453.27 ms 100.65 ms
a04f788 321.78 ms 354.12 ms 32.35 ms
4a9c176 319.77 ms 363.20 ms 43.43 ms
90e9745 314.68 ms 357.28 ms 42.60 ms
3695453 314.63 ms 353.10 ms 38.47 ms
16371c5 314.02 ms 394.54 ms 80.52 ms
507f924 342.51 ms 402.65 ms 60.14 ms
703d523 330.27 ms 377.66 ms 47.39 ms
4a9c176 320.62 ms 334.68 ms 14.06 ms
87598a5 310.41 ms 373.27 ms 62.86 ms

App size

Revision Plain With Sentry Diff
f1150bc 1.73 MiB 2.33 MiB 615.66 KiB
a04f788 1.73 MiB 2.32 MiB 609.88 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
90e9745 1.73 MiB 2.32 MiB 608.63 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
16371c5 1.73 MiB 2.32 MiB 611.62 KiB
507f924 1.73 MiB 2.32 MiB 609.95 KiB
703d523 1.73 MiB 2.33 MiB 613.23 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
87598a5 1.73 MiB 2.33 MiB 614.63 KiB

Previous results on branch: feat/test-error-otel-transaction-link

Startup times

Revision Plain With Sentry Diff
fa42bf4 303.78 ms 353.70 ms 49.93 ms
1d94fa8 330.26 ms 403.30 ms 73.04 ms

App size

Revision Plain With Sentry Diff
fa42bf4 1.73 MiB 2.33 MiB 613.23 KiB
1d94fa8 1.73 MiB 2.33 MiB 615.83 KiB

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 80.05% // Head: 80.03% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9cdea77) compared to base (9b794df).
Patch coverage: 63.91% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2425      +/-   ##
============================================
- Coverage     80.05%   80.03%   -0.03%     
- Complexity     3802     3806       +4     
============================================
  Files           306      306              
  Lines         14312    14402      +90     
  Branches       1903     1904       +1     
============================================
+ Hits          11458    11527      +69     
- Misses         2108     2127      +19     
- Partials        746      748       +2     
Impacted Files Coverage Δ
...java/io/sentry/opentelemetry/SentryPropagator.java 66.66% <42.10%> (-12.83%) ⬇️
...elemetry/OpenTelemetryLinkErrorEventProcessor.java 69.23% <61.53%> (+69.23%) ⬆️
...a/io/sentry/opentelemetry/SentrySpanProcessor.java 86.74% <73.07%> (-4.99%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adinauer adinauer mentioned this pull request Dec 22, 2022
21 tasks
@adinauer adinauer merged commit 93fbd16 into main Dec 22, 2022
@adinauer adinauer deleted the feat/test-error-otel-transaction-link branch December 22, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants