Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OkHttp event spans #2659

Merged
merged 14 commits into from
May 26, 2023
Merged

Add OkHttp event spans #2659

merged 14 commits into from
May 26, 2023

Commits on Apr 11, 2023

  1. added SentryNetworkCallEventListener with spans for each callback 

    made SentryOkHttpInterceptor work nicely with SentryNetworkCallEventListener
    @stefanosiano
    stefanosiano committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d9e6658 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Merge branch 'main' into feat/okhttp-event-spans

    @stefanosiano
    stefanosiano committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    de54a97 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. added SentryOkHttpEventListener 

    added SentryOkHttpEvent
added tests
    @stefanosiano
    stefanosiano committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    28946fe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/okhttp-event-spans

    @stefanosiano
    stefanosiano authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    cf71d30 View commit details
    Browse the repository at this point in the history

  3. updated changelog and sample app

    @stefanosiano
    stefanosiano committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    6853cc5 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/feat/okhttp-event-spans' into fe… 

    …at/okhttp-event-spans
    @stefanosiano
    stefanosiano committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    f3e42ab View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. moved uuid regex as static member

    @stefanosiano
    stefanosiano committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    b1d9eab View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. updated changelog 

    SentryOkHttpEventListener now accepts an instance of EventListener or EventListener.Factory and propagate all the calls to it
    @stefanosiano
    stefanosiano committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    a8b3171 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. updated span data to align with https://develop.sentry.dev/sdk/perfor… 

    …mance/span-data-conventions/

OkHttp event spans are now children of specific spans. E.g. secureConnect is a child of connect
updated changelog
    @stefanosiano
    stefanosiano committed May 8, 2023
    Configuration menu
    Copy the full SHA
    d2cd6c5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/okhttp-event-spans

    @stefanosiano
    stefanosiano authored May 8, 2023
    Configuration menu
    Copy the full SHA
    9758a98 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. SentryOkHttpEvent now takes a Request instead of a Call in the ctor 

    Removed `http.` prefix from the breadcrumb
Updated sub-spans with operation from `http.client` to `http.client.details`
removed filtered_url from SentryOkHttpEvent
    @stefanosiano
    stefanosiano committed May 22, 2023
    Configuration menu
    Copy the full SHA
    9cd233c View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. removed duplicated breadcrumb data 

    removed `success` from http span as it's implied by the http.status_code
http sub-spans operation now contains the event, and the description is now empty
    @stefanosiano
    stefanosiano committed May 23, 2023
    Configuration menu
    Copy the full SHA
    66d6ab8 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. added SentryOkHttpEventListener empty constructors

    @stefanosiano
    stefanosiano committed May 25, 2023
    Configuration menu
    Copy the full SHA
    06d74ff View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. updated http operations to be snake_case

    @stefanosiano
    stefanosiano committed May 26, 2023
    Configuration menu
    Copy the full SHA
    247ceb3 View commit details
    Browse the repository at this point in the history