Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ANRv2 implementation based on ApplicationExitInfo #2697

Merged
merged 32 commits into from
May 5, 2023
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented May 4, 2023

📜 Description

Integration branch for #2549 #2621 #2661

💡 Motivation and Context

Closes #1796

💚 How did you test it?

Manually and automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

getsentry/team-mobile#115

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d5f6ffb

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 343.50 ms 435.50 ms 92.00 ms
Size 1.72 MiB 2.28 MiB 565.94 KiB

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 69.54% and project coverage change: -0.27 ⚠️

Comparison is base (59a452f) 81.32% compared to head (893ecf8) 81.05%.

❗ Current head 893ecf8 differs from pull request most recent head d5f6ffb. Consider uploading reports for the commit d5f6ffb to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2697      +/-   ##
============================================
- Coverage     81.32%   81.05%   -0.27%     
- Complexity     4271     4427     +156     
============================================
  Files           337      345       +8     
  Lines         15796    16355     +559     
  Branches       2083     2219     +136     
============================================
+ Hits          12846    13257     +411     
- Misses         2127     2170      +43     
- Partials        823      928     +105     
Impacted Files Coverage Δ
...ntry/src/main/java/io/sentry/IOptionsObserver.java 0.00% <0.00%> (ø)
sentry/src/main/java/io/sentry/IScopeObserver.java 0.00% <0.00%> (ø)
sentry/src/main/java/io/sentry/IpAddressUtils.java 66.66% <ø> (ø)
...ry/src/main/java/io/sentry/MainEventProcessor.java 85.31% <ø> (-0.11%) ⬇️
sentry/src/main/java/io/sentry/NoOpSerializer.java 37.50% <0.00%> (-5.36%) ⬇️
...entry/src/main/java/io/sentry/SentryBaseEvent.java 90.90% <ø> (ø)
sentry/src/main/java/io/sentry/SentryEvent.java 89.36% <0.00%> (-1.29%) ⬇️
...y/src/main/java/io/sentry/SentryThreadFactory.java 97.36% <ø> (ø)
...entry/src/main/java/io/sentry/protocol/Device.java 88.73% <12.82%> (-7.79%) ⬇️
sentry/src/main/java/io/sentry/protocol/Gpu.java 88.79% <15.38%> (-9.27%) ⬇️
... and 30 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consider using a more accurate ANR tracking implementation
3 participants