Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude SentryOptions from obfuscation #2699

Merged
merged 30 commits into from
May 16, 2023
Merged

Conversation

markushi
Copy link
Member

@markushi markushi commented May 4, 2023

📜 Description

Fixes #2696

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 300.76 ms 348.92 ms 48.16 ms
Size 1.72 MiB 2.28 MiB 570.00 KiB

Previous results on branch: fix/r8_full_mode_nosuchelement

Startup times

Revision Plain With Sentry Diff
37008e8 316.25 ms 371.59 ms 55.34 ms
637ab0a 344.50 ms 414.98 ms 70.48 ms
bb4eede 268.84 ms 350.02 ms 81.19 ms
909763b 301.30 ms 378.10 ms 76.80 ms
a3f35ac 303.04 ms 338.38 ms 35.34 ms
8b99497 308.80 ms 352.80 ms 44.00 ms

App size

Revision Plain With Sentry Diff
37008e8 1.72 MiB 2.26 MiB 553.42 KiB
637ab0a 1.72 MiB 2.28 MiB 565.45 KiB
bb4eede 1.72 MiB 2.28 MiB 565.88 KiB
909763b 1.72 MiB 2.28 MiB 570.00 KiB
a3f35ac 1.72 MiB 2.28 MiB 565.45 KiB
8b99497 1.72 MiB 2.28 MiB 565.45 KiB

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (6a11214) 81.10% compared to head (09f9a1a) 81.11%.

❗ Current head 09f9a1a differs from pull request most recent head 7e8e5f5. Consider uploading reports for the commit 7e8e5f5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2699      +/-   ##
============================================
+ Coverage     81.10%   81.11%   +0.01%     
  Complexity     4445     4445              
============================================
  Files           345      345              
  Lines         16387    16387              
  Branches       2226     2226              
============================================
+ Hits          13291    13293       +2     
+ Misses         2167     2166       -1     
+ Partials        929      928       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn self-assigned this May 4, 2023
@helloword1
Copy link

辛苦大佬们了。

@romtsn romtsn merged commit 360297d into main May 16, 2023
@romtsn romtsn deleted the fix/r8_full_mode_nosuchelement branch May 16, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R8 full mode causes NoSuchElementException in Sentry.init
5 participants