Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Base64.NO_WRAP to avoid unexpected char errors in Apollo #2745

Merged
merged 3 commits into from
May 30, 2023

Conversation

adinauer
Copy link
Member

📜 Description

💡 Motivation and Context

Fixes #2737

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 300.60 ms 341.10 ms 40.50 ms
Size 1.72 MiB 2.28 MiB 570.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
16cd2b6 243.02 ms 349.69 ms 106.67 ms
46b1782 387.72 ms 458.74 ms 71.02 ms
1707044 338.80 ms 384.79 ms 46.00 ms

App size

Revision Plain With Sentry Diff
16cd2b6 1.72 MiB 2.28 MiB 570.95 KiB
46b1782 1.72 MiB 2.28 MiB 570.44 KiB
1707044 1.72 MiB 2.28 MiB 570.44 KiB

Previous results on branch: fix/base-64-no-eol

Startup times

Revision Plain With Sentry Diff
c8c3414 333.65 ms 351.08 ms 17.43 ms

App size

Revision Plain With Sentry Diff
c8c3414 1.72 MiB 2.28 MiB 570.95 KiB

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a62c875) 81.10% compared to head (ce05a0b) 81.10%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2745   +/-   ##
=========================================
  Coverage     81.10%   81.10%           
  Complexity     4455     4455           
=========================================
  Files           344      344           
  Lines         16420    16420           
  Branches       2227     2227           
=========================================
  Hits          13317    13317           
  Misses         2174     2174           
  Partials        929      929           
Impacted Files Coverage Δ
.../io/sentry/apollo3/SentryApollo3HttpInterceptor.kt 81.18% <100.00%> (ø)
...java/io/sentry/apollo3/SentryApollo3Interceptor.kt 64.28% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, is it also possible to add a test for this (which would've failed without the fix)?

@adinauer
Copy link
Member Author

is it also possible to add a test for this (which would've failed without the fix)?

Sadly I haven't been able to reproduce the issue but the fix seems quite logical so I'd say it's OK to get it fixed and take another look at adding tests later on. @lbloder also tried reproducing similar problems and wasn't able to reproduce before IIRC.

@adinauer adinauer merged commit f0c28a1 into main May 30, 2023
@adinauer adinauer deleted the fix/base-64-no-eol branch May 30, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected char 0x0a at 8 in SENTRY-APOLLO-3-OPERATION-TYPE value: cXVlcnk=
2 participants