-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Base64.NO_WRAP to avoid unexpected char errors in Apollo #2745
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
16cd2b6 | 243.02 ms | 349.69 ms | 106.67 ms |
46b1782 | 387.72 ms | 458.74 ms | 71.02 ms |
1707044 | 338.80 ms | 384.79 ms | 46.00 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
16cd2b6 | 1.72 MiB | 2.28 MiB | 570.95 KiB |
46b1782 | 1.72 MiB | 2.28 MiB | 570.44 KiB |
1707044 | 1.72 MiB | 2.28 MiB | 570.44 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2745 +/- ##
=========================================
Coverage 81.10% 81.10%
Complexity 4455 4455
=========================================
Files 344 344
Lines 16420 16420
Branches 2227 2227
=========================================
Hits 13317 13317
Misses 2174 2174
Partials 929 929
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, is it also possible to add a test for this (which would've failed without the fix)?
Sadly I haven't been able to reproduce the issue but the fix seems quite logical so I'd say it's OK to get it fixed and take another look at adding tests later on. @lbloder also tried reproducing similar problems and wasn't able to reproduce before IIRC. |
📜 Description
💡 Motivation and Context
Fixes #2737
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps