Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile rate limiting #2782

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Conversation

stefanosiano
Copy link
Member

📜 Description

added profile rate limiting
added Profile type in ClientReportRecorder, DataCategory and RateLimiter

💡 Motivation and Context

Closes #2017

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

added Profile type in ClientReportRecorder, DataCategory and RateLimiter
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 165fde9

@stefanosiano stefanosiano marked this pull request as ready for review June 9, 2023 09:26
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 296.10 ms 359.98 ms 63.88 ms
Size 1.72 MiB 2.28 MiB 571.82 KiB

Previous results on branch: feat/android-profile-rate-limit

Startup times

Revision Plain With Sentry Diff
91ece86 338.16 ms 355.02 ms 16.86 ms

App size

Revision Plain With Sentry Diff
91ece86 1.72 MiB 2.28 MiB 571.76 KiB

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (3bb708a) 81.13% compared to head (fb1f07a) 81.11%.

❗ Current head fb1f07a differs from pull request most recent head 165fde9. Consider uploading reports for the commit 165fde9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2782      +/-   ##
============================================
- Coverage     81.13%   81.11%   -0.03%     
+ Complexity     4493     4481      -12     
============================================
  Files           348      347       -1     
  Lines         16659    16514     -145     
  Branches       2263     2239      -24     
============================================
- Hits          13517    13396     -121     
+ Misses         2197     2183      -14     
+ Partials        945      935      -10     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/DataCategory.java 100.00% <100.00%> (ø)
...a/io/sentry/clientreport/ClientReportRecorder.java 69.73% <100.00%> (+0.81%) ⬆️
...src/main/java/io/sentry/transport/RateLimiter.java 88.77% <100.00%> (+0.11%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanosiano stefanosiano enabled auto-merge (squash) June 13, 2023 15:50
@stefanosiano stefanosiano merged commit 8820c5c into main Jun 13, 2023
@stefanosiano stefanosiano deleted the feat/android-profile-rate-limit branch June 13, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rate limiting for profile envelope items
2 participants